Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): add @babel/preset-env in dependencies #3413

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

MichaelDeBoey
Copy link
Member

I also took the liberty of updating all @babel/* deps to their latest minor


Fixes remix-run/indie-stack#97

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Where do we use this plugin?

@kentcdodds
Copy link
Member

Ah, I failed to look at the linked issue.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds
Copy link
Member

Hmm... Can you help me figure out why the install is failing on CI for this change?

@MichaelDeBoey
Copy link
Member Author

@kentcdodds Don't know what went wrong, but a rebase seems to have fixed it

@kentcdodds kentcdodds merged commit c2f6bf4 into remix-run:dev Jun 8, 2022
@kentcdodds
Copy link
Member

Thanks!

@MichaelDeBoey MichaelDeBoey deleted the fix-dependencies branch June 8, 2022 01:02
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-c2f6bf4-20220608 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants