Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): update .env.example of firebase-auth-firestore example #3329

Merged
merged 1 commit into from
May 30, 2022

Conversation

johnpolacek
Copy link
Contributor

This is an update to .env.example for the Firebase Auth Example that makes it more clear what goes where and how to format.

  • Docs
  • Tests
  • Examples

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 29, 2022

Hi @johnpolacek,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 29, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Provide better guidance of how to bring Firebase credentials into your `.env` file.
@machour machour changed the title Improve Firebase Auth .env.example docs(examples/firebase): Improve Firebase Auth .env.example May 30, 2022
@MichaelDeBoey MichaelDeBoey changed the title docs(examples/firebase): Improve Firebase Auth .env.example docs(examples): update .env.example of firebase-auth-firestore example May 30, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I definitely appreciate this 👍 Thank you!

@kentcdodds kentcdodds merged commit 4b11c6d into remix-run:main May 30, 2022
eastlondoner pushed a commit to eastlondoner/remix that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants