-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add link to EdgeDB
variant of jokes
example
#3268
Conversation
Hi @colinhacks, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thank you for pulling this example together @colinhacks ! My first sentiment is that the example should focus solely on the EdgeDb part (and drop the metas, etc) but since this is an adaptation of the jokes tutorials, not sure how we would like to handle this. What would @kentcdodds do? |
I would personally make all the examples as small as possible & only focus on what technology your trying to show.
|
Agreed! I do feel like there's value here though. Here's what I suggest @colinhacks: put this example in your personal repo and update the README of the jokes example to point to yours as a comparison. May be interesting to start your git repo with the original jokes app and make a branch with that, then update to EdgeDB and link people to a diff. |
d278ef0
to
3067bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one thing.
0e17b34
to
0e31e32
Compare
0e31e32
to
57083b3
Compare
EdgeDB
variant of jokes
example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Thanks!
…x-run#3268) * Add EdgeDB example * Add name to contributors * Finalize README * Update readme * Add mention of EdgeDB jokes variant to readme
…x-run#3268) * Add EdgeDB example * Add name to contributors * Finalize README * Update readme * Add mention of EdgeDB jokes variant to readme
Adding a variant of the
jokes
example that uses EdgeDB instead of SQLite/Prisma.