Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): improve appTemplate message #3249

Merged
merged 2 commits into from
May 19, 2022
Merged

fix(remix-dev): improve appTemplate message #3249

merged 2 commits into from
May 19, 2022

Conversation

nvh95
Copy link
Contributor

@nvh95 nvh95 commented May 19, 2022

When running npx create-remix@latest, The CLI asks me

"Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets."

But there is no option such as Remix, but Remix App Server. This PR is to make users not confused when first using create-remix

using create-remix to bootstrap a remix project

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 19, 2022

Hi @nvh95,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 19, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Improve the instruction to make it clearer during bootstrapping fix(remix-dev): improve appTemplate message May 19, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev May 19, 2022 13:40
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main May 19, 2022 13:41
@MichaelDeBoey
Copy link
Member

@nvh95 Code changes need to go against dev.
Could you please rebase your branch onto dev & set base branch to dev as well?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 19, 2022
@nvh95 nvh95 changed the base branch from main to dev May 19, 2022 13:47
@nvh95
Copy link
Contributor Author

nvh95 commented May 19, 2022

@MichaelDeBoey Yeah. I did. Can you check again?

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 19, 2022
@kentcdodds kentcdodds merged commit a96c26a into remix-run:dev May 19, 2022
@nvh95
Copy link
Contributor Author

nvh95 commented May 20, 2022

@nvh95 Code changes need to go against dev.

@MichaelDeBoey I think if any code changes need to go against dev, then remix repository should set the default branch to dev, instead of main, it will be easier to contributors to create PRs.
cc: @kentcdodds

@kentcdodds
Copy link
Member

I'm pretty sure the majority of PRs are for docs/examples/templates which need to go into main. Additionally, folks contributing code normally take more care about something like that than someone contributing to docs. I think we've got the right default.

@nvh95
Copy link
Contributor Author

nvh95 commented May 20, 2022 •
edited
Loading

@kentcdodds I see, it's clear that I haven't checked out the CONTRIBUTING guide. Thanks.
contributing guide for remix

In short:

  • docs/ example/ templates PRs => PR to main
  • Touches code => PR to dev

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-000f37c-20220520 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 21, 2022
@nvh95
fix(remix-dev): improve appTemplate message (remix-run#3249)
53b568b
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d19d888-20220522 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@nvh95 nvh95 mentioned this pull request May 26, 2022
Merged
2 tasks
justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@nvh95 @justjavac
fix(remix-dev): improve appTemplate message (remix-run#3249)
43d182f
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@machour machour machour approved these changes

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed package:create-remix package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvh95 @MichaelDeBoey @kentcdodds @machour