chore(templates): bring deno template in line with other templates
#3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
update-deno-template
branch
2 times, most recently
from
313a8f6 to
d73e0da
Compare
pcattori
requested changes
May 18, 2022
There was a problem hiding this comment.
Most of these changes are preferences (like import ordering and such) that don't affect the correctness, readability, or maintainability of the user's code.
I'd prefer if this PR just included:
- updates to the version specs in the import map
- link to the Remix config docs in
remix.config.js - importing
hydrateas a named export inentry.client.tsx
MichaelDeBoey
force-pushed
the
update-deno-template
branch
3 times, most recently
from
a6d9f26 to
4de79c0
Compare
MichaelDeBoey
force-pushed
the
update-deno-template
branch
2 times, most recently
from
a0d2423 to
ed2b800
Compare
pcattori
reviewed
May 18, 2022
pcattori
approved these changes
May 18, 2022
|
@MichaelDeBoey we probably want to target |
MichaelDeBoey
force-pushed
the
update-deno-template
branch
from
ed2b800 to
eb7114e
Compare
pcattori
approved these changes
May 18, 2022
pcattori
added a commit
that referenced
this pull request
May 19, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (#3221) * docs: fix links to decision docs (#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
christophertrudel
pushed a commit
to christophertrudel/remix
that referenced
this pull request
May 21, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (remix-run#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (remix-run#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (remix-run#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (remix-run#3221) * docs: fix links to decision docs (remix-run#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
eastlondoner
pushed a commit
to eastlondoner/remix
that referenced
this pull request
Jun 8, 2022
justjavac
pushed a commit
to justjavac/remix
that referenced
this pull request
Jun 11, 2022
* fix(templates/vercel): add `index.js.map` to `.gitignore` (remix-run#3216) * Add `index.js.map` to `.gitignore` In the Vercel template, `/api/index.js.map` should also be ignored along with `/api/index.js`. Otherwise, that mapping file would be committed into version control, which is not desired. * Sign CLA * fix(scripts): Prevent publishing without a tag (remix-run#3223) * move decisions * docs: add `decisions/index.md` and frontmatter (remix-run#3226) Co-authored-by: Pedro Cattori <pcattori@gmail.com> (cherry picked from commit e809206) * docs(server-runtime): update link for deno server runtime package (remix-run#3228) since it's now a proper package * chore(templates): bring `deno` template in line with other templates (remix-run#3221) * docs: fix links to decision docs (remix-run#3231) * chore: update Deno import maps on release Co-authored-by: Jiahao <8275280+jiahao-c@users.noreply.github.com> Co-authored-by: Chance Strickland <hi@chance.dev> Co-authored-by: Ryan Florence <rpflorence@gmail.com> Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.