docs(examples): ignore routes.d.ts and generate it automatically in routes-gen example
#3019
Conversation
|
Hi @frontsideair, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
routes.d.ts and generate it automatically in routes-gen example
|
@frontsideair Examples go against |
MichaelDeBoey
added
the
needs-response
|
Done! |
github-actions
bot
removed
the
needs-response
|
@frontsideair It seems like something went wrong while rebasing & you only changed the base branch of the PR. Running the following command should fix it though: git reset --hard main && git cherry-pick 6126f4e && git cherry-pick b5e8aea && git push -f |
MichaelDeBoey
added
the
needs-response
frontsideair
force-pushed
the
ignore-routes-gen-typings
branch
from
2871dd1 to
de1290e
Compare
|
Should be fine now. |
github-actions
bot
removed
the
needs-response
|
@frontsideair You still have some commits in your branch that aren't supposed to be here. git reset --hard main && git cherry-pick 2170332 && git cherry-pick 1d2bcd3 && git cherry-pick de1290e && git push -f |
MichaelDeBoey
added
the
needs-response
frontsideair
force-pushed
the
ignore-routes-gen-typings
branch
from
de1290e to
5718668
Compare
|
Woah, my bad. Fixed it now, thanks! |
github-actions
bot
removed
the
needs-response
… `routes-gen` example (remix-run#3019) * Ignore routes.d.ts and generate it automatically * Add frontsideair to the contributors list * Move route generation to build step
… `routes-gen` example (remix-run#3019) * Ignore routes.d.ts and generate it automatically * Add frontsideair to the contributors list * Move route generation to build step
… `routes-gen` example (remix-run#3019) * Ignore routes.d.ts and generate it automatically * Add frontsideair to the contributors list * Move route generation to build step
… `routes-gen` example (remix-run#3019) * Ignore routes.d.ts and generate it automatically * Add frontsideair to the contributors list * Move route generation to build step
In routes-gen example, it would be a better pattern to not commit the autogenerated route typings to the repo, instead generating them after install so they can be there for the CI.