Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint to report misused type imports #301

Merged
merged 14 commits into from
Oct 7, 2021
Merged

chore: update eslint to report misused type imports #301

merged 14 commits into from
Oct 7, 2021

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Oct 7, 2021

Signed-off-by: Logan McAnsh logan@mcan.sh

mcansh added 5 commits October 6, 2021 21:10
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
…to latest

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, @mcansh!

.eslintrc.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
mcansh added 2 commits October 6, 2021 22:56
…eslint configs

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh changed the title chore: add eslint and configure it to only report type imports chore: update eslint and configure it to only report type imports Oct 7, 2021
@mcansh mcansh changed the title chore: update eslint and configure it to only report type imports chore: update eslint to report type imports Oct 7, 2021
@mcansh mcansh changed the title chore: update eslint to report type imports chore: update eslint to report misused type imports Oct 7, 2021
Signed-off-by: Logan McAnsh <logan@mcan.sh>
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, but otherwise lgtm!

mcansh added 6 commits October 7, 2021 10:01
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh merged commit 7eb6a63 into dev Oct 7, 2021
@mcansh mcansh deleted the eslint branch October 7, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants