Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server-runtime): default cookies to sameSite: "lax" #2388

Merged
merged 1 commit into from
May 19, 2022
Merged

feat(server-runtime): default cookies to sameSite: "lax" #2388

merged 1 commit into from
May 19, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Mar 18, 2022 •
edited
Loading

Resolves #200

@mcansh
Copy link
Collaborator

mcansh commented Mar 18, 2022

LGTM, might be more of a "feature" than a "fix" though 😉

@machour machour linked an issue Mar 18, 2022 that may be closed by this pull request
default cookies to SameSite: Lax #200
Closed
@MichaelDeBoey MichaelDeBoey changed the title fix(server-runtime): Default cookies to sameSite: "lax" feat(server-runtime): default cookies to sameSite: "lax" Mar 20, 2022
@chaance chaance closed this Apr 17, 2022
@chaance chaance deleted the chance/cookie-defaults branch April 17, 2022 13:50
@chaance chaance restored the chance/cookie-defaults branch April 19, 2022 02:36
@chaance chaance reopened this Apr 19, 2022
@MichaelDeBoey
Copy link
Member

@chaance The way cookies are handled changed a bit, so there are some conflicts that need to be solved now.

@chaance chaance force-pushed the chance/cookie-defaults branch from f40200d to abbf64a Compare May 19, 2022 17:09
@chaance chaance merged commit 000f37c into dev May 19, 2022
@chaance chaance deleted the chance/cookie-defaults branch May 19, 2022 17:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-000f37c-20220520 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 20, 2022
Closed
christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 21, 2022
@chaance
feat(server-runtime): default cookies to sameSite: 'lax' (remix-run#2388
4fc389b 
)
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d19d888-20220522 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@chaance @justjavac
feat(server-runtime): default cookies to sameSite: 'lax' (remix-run#2388
20a87b7 
)
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@ragrawal1234 ragrawal1234 mentioned this pull request May 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed feat:cookies package:server-runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default cookies to SameSite: Lax
3 participants
@chaance @mcansh @MichaelDeBoey