Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move deployment test dependencies out of main remix deps #2080

Merged
merged 22 commits into from
Feb 23, 2022
Merged

ci: move deployment test dependencies out of main remix deps #2080

merged 22 commits into from
Feb 23, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Feb 22, 2022 •
edited
Loading

This PR does the following:

  • installs create-remix from npm instead of using the built version from build
    • doing so, allows us to not have to rebuild remix during each deployment job
  • moves dependencies that are only used by the deployment tests to scripts/deployment-test/package.json
    • allows us to not have to install unused deps when working on remix itself
  • explicitly adds the various CLIs used to dependencies
  • updates 'checkUp' function

with all of that said, we cut out a nice chunk of time for each deployment Group 2

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

@mcansh
ci: move deployment test dependencies out of main remix deps
5dac18b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: remove @octokit/rest from main remix dependencies
3fb7e1f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: update deployment-test.yml
a645ce0 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: drop needs
c025734 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: add caching
a98109b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh added 12 commits February 22, 2022 17:15
@mcansh
ci: use v2 of node action
3c92bc4 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: set working directory
19c2d67 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Merge branch 'dev' into logan/use-create-remix-from-npm
623ccaf
@mcansh
ci: more working-directory
fc66e95 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: more working-directory
59ce86d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: coerce versions when checking for them on npm
d0fb69e 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: esm import for semver
fa923ae 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: esm import for semver
fc8bee1 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: cypress dir will now be in the cwd
9d09d22 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: add missing shared deps
24a2917 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: remove unused export
2734f3e 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
ci: update saving current git user
aeadfa8 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as ready for review February 22, 2022 22:52
@mcansh mcansh requested a review from mjackson February 22, 2022 22:52
@mcansh
ci: remove push trigger
695add7 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as draft February 22, 2022 22:55
@mcansh
chore: update retry logic
7783cf1 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: re-enable push trigger
3775b70 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Revert "chore: re-enable push trigger"
6c51bb0 
This reverts commit 3775b70.
@mcansh mcansh marked this pull request as ready for review February 23, 2022 02:04
@mcansh
ci: use a more robust retry
7ff303f 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mjackson
mjackson approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @mcansh! Thank you! 👏

@mcansh mcansh merged commit d95e6bd into dev Feb 23, 2022
@mcansh mcansh deleted the logan/use-create-remix-from-npm branch February 23, 2022 17:57
jstafman pushed a commit to jstafman/remix that referenced this pull request Mar 18, 2022
@mcansh @jstafman
ci: move deployment test dependencies out of main remix deps (remix-r…
e8f9b26 
…un#2080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@mjackson mjackson mjackson approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcansh @mjackson @MichaelDeBoey