refactor(gdpr-cookie-consent): Switch to V2 + Vite #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machour
commented
Jun 16, 2024
gdpr-cookie-consent/app/root.tsx
Outdated
| }); | ||
|
|
||
| export default function App() { | ||
| export function Layout({ children }: { children: React.ReactNode }) { | ||
| const { track } = useLoaderData<typeof loader>(); |
There was a problem hiding this comment.
@sergiodxa Little problem here, Layout shouldn't be calling useLoaderData() since it would fail when an error is thrown.
Tried calling useLoaderData() from and pass track in the Outlet (<Outlet context={{ track }} />) but useOutletContext() returns null in Layout (which seems normal since we're still in the same route, not in a descendant).
I'm curious how you would handle this? Dummy ErrorBoundary that doesn't use Layout ? A context ?
There was a problem hiding this comment.
Went with useRouteLoaderData() as a workaround. Still curious about your opinion here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.