Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell and ComboBox updates #434

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Conversation

rzerres
Copy link
Contributor

@rzerres rzerres commented Mar 5, 2021

shell: Documentation updates

  • rearrange enum 'Key' and impl 'From' in lexical order
  • add documentation for public definitions
  • rearrange key_event.scancode in lexical order
  • add Tabulator identifier key (K_TAB)

open

assign a keycode to new identifier K_TAB

Contribution checklist:

  • Add documentation to all public structs, traits and functions.
  • Run cargo fmt to make the formatting consistent across the codebase
  • Run cargo clippy to check with the linter

* rearrange enum 'Key' and impl 'From<Key>' in lexical order
* add documentation for public definitions
* rearrange key_event.scancode in lexical order
* add Tabulator identifier key (K_TAB)

Signed-off-by: Ralf Zerres <ralf.zerres@networkx.de>
* remove duplicate definition assignment for
  `build_context.register_shared_property::<f32>

Signed-off-by: Ralf Zerres <ralf.zerres@networkx.de>
@rzerres rzerres changed the title crate:shell updates Shell and ComboBox updates Mar 5, 2021
@rzerres
Copy link
Contributor Author

rzerres commented Mar 6, 2021

Linter Problem

solution also comitted with c1e587d in PR #304.
Might clash, depends on which PR is merged first.

@rzerres rzerres requested a review from FloVanGH March 6, 2021 11:22
* overcome lint error

Signed-off-by: Ralf Zerres <ralf.zerres@networkx.de>
@FloVanGH
Copy link
Contributor

FloVanGH commented Mar 8, 2021

Thank you

@FloVanGH FloVanGH merged commit 5cf60b6 into redox-os:develop Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants