This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
cherry-pick(release-v1.3.x): Create cluster-wide resources only once in performance test (#1308) #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Currently, the performance as part of simulated users actions it applies YAML files with resources. Those resources contain also the cluster-wide resources such as ClusterRole or ClusterWorkloadResourceMapping.
Since that YAML is applied by each of the simulated users those cluster-wide resources are constantly being "updated" by which sometimes causes the "the object has been modified; please apply your changes to the latest version and try again" error that fails the test.
That causes the performance testing jobs to be flaky.
Changes
This PR fixes the situation by applying the cluster-wide resources only once instead of for each for each iteration.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.