Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 11, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Project a v1beta1 service binding using a v1beta1 workload mapping scenario is present twice in exact copies.

Changes

This PR removes the duplicate scenario.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik added approved lgtm cherry-pick release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1265 (b4f6631) into release-v1.3.x (412fe0e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1265   +/-   ##
===============================================
  Coverage           58.06%   58.06%           
===============================================
  Files                  33       33           
  Lines                2797     2797           
===============================================
  Hits                 1624     1624           
  Misses               1018     1018           
  Partials              155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412fe0e...b4f6631. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit b44aa84 into redhat-developer:release-v1.3.x Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants