Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 6, 2022

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added cherry-pick release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch labels Sep 6, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

Acceptance testing jobs failed because DNS issue in OpenShift CI. That should be fixed now...
/retest

@pmacik pmacik added this to the 1.2.0 milestone Sep 6, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

/test 4.10-acceptance

@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

/retest

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1216 (0d44919) into release-v1.2.x (662f5f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.2.x    #1216   +/-   ##
===============================================
  Coverage           58.05%   58.05%           
===============================================
  Files                  33       33           
  Lines                2844     2844           
===============================================
  Hits                 1651     1651           
  Misses               1032     1032           
  Partials              161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662f5f2...0d44919. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c04aee7 into redhat-developer:release-v1.2.x Sep 7, 2022
@pmacik pmacik deleted the cherry-pick_release-v1.2.x_8563a7c830a648813d9c0c4558c7b43a266f933f branch October 11, 2022 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants