Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lower_acl_than_parent rule rewriter by preserving leading whitespace #4861

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix lower_acl_than_parent rule rewriter by preserving leading whitespace #4861

merged 2 commits into from
Apr 3, 2023

Conversation

SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented Apr 3, 2023 •
edited
Loading

Fixes #4860.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 3, 2023 •
edited
Loading

3 Warnings
⚠️ This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/issue-57089.swift:34:3: warning: Lower ACL than Parent Violation: Ensure declarations have a lower access control level than their enclosing parent (lower_acl_than_parent)
⚠️ This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/rdar64265821.swift:4:3: warning: Lower ACL than Parent Violation: Ensure declarations have a lower access control level than their enclosing parent (lower_acl_than_parent)
⚠️ This PR introduced a violation in Swift: /validation-test/IDE/crashers_2_fixed/rdar69246891.swift:5:3: warning: Lower ACL than Parent Violation: Ensure declarations have a lower access control level than their enclosing parent (lower_acl_than_parent)
18 Messages
📖 Linting Aerial with this PR took 0.14s vs 0.13s on main (7% slower)
📖 Linting Alamofire with this PR took 0.1s vs 0.1s on main (0% slower)
📖 Linting Brave with this PR took 0.48s vs 0.48s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 0.27s vs 0.27s on main (0% slower)
📖 Linting Firefox with this PR took 0.46s vs 0.46s on main (0% slower)
📖 Linting Kickstarter with this PR took 0.58s vs 0.6s on main (3% faster)
📖 Linting Moya with this PR took 0.11s vs 0.11s on main (0% slower)
📖 Linting NetNewsWire with this PR took 0.21s vs 0.21s on main (0% slower)
📖 Linting Nimble with this PR took 0.09s vs 0.09s on main (0% slower)
📖 Linting PocketCasts with this PR took 0.46s vs 0.46s on main (0% slower)
📖 Linting Quick with this PR took 0.06s vs 0.06s on main (0% slower)
📖 Linting Realm with this PR took 0.43s vs 0.43s on main (0% slower)
📖 Linting SourceKitten with this PR took 0.08s vs 0.08s on main (0% slower)
📖 Linting Sourcery with this PR took 0.2s vs 0.2s on main (0% slower)
📖 Linting Swift with this PR took 1.02s vs 1.02s on main (0% slower)
📖 Linting VLC with this PR took 0.13s vs 0.14s on main (7% faster)
📖 Linting Wire with this PR took 0.54s vs 0.53s on main (1% slower)
📖 Linting WordPress with this PR took 0.72s vs 0.72s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) April 3, 2023 20:06
@SimplyDanny SimplyDanny merged commit bd444fc into realm:main Apr 3, 2023
@SimplyDanny SimplyDanny deleted the fix-rewriter branch April 3, 2023 20:37
@jpsim jpsim mentioned this pull request May 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lower_acl_than_parent not safe
2 participants
@SimplyDanny @SwiftLintBot