Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run analyze on CI with --strict #2524

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Run analyze on CI with --strict #2524

merged 1 commit into from
Dec 24, 2018

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Dec 24, 2018

and whitelist two intentional violations.

and whitelist two intentional violations
@SwiftLintBot
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 2.41s vs 2.1s on master (14% slower)
📖 Linting Alamofire with this PR took 5.36s vs 4.36s on master (22% slower)
📖 Linting Firefox with this PR took 19.57s vs 14.81s on master (32% slower)
📖 Linting Kickstarter with this PR took 27.04s vs 22.85s on master (18% slower)
📖 Linting Moya with this PR took 2.46s vs 2.26s on master (8% slower)
📖 Linting Nimble with this PR took 2.02s vs 2.08s on master (2% faster)
📖 Linting Quick with this PR took 0.63s vs 0.66s on master (4% faster)
📖 Linting Realm with this PR took 4.02s vs 4.07s on master (1% faster)
📖 Linting SourceKitten with this PR took 1.28s vs 1.34s on master (4% faster)
📖 Linting Sourcery with this PR took 5.32s vs 5.37s on master (0% faster)
📖 Linting Swift with this PR took 32.21s vs 33.26s on master (3% faster)
📖 Linting WordPress with this PR took 23.59s vs 23.15s on master (1% slower)

Here's an example of your CHANGELOG entry:

* Run analyze on CI with --strict.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim jpsim merged commit e6ff352 into master Dec 24, 2018
@jpsim jpsim deleted the enable-analyze-strict-on-ci branch December 24, 2018 02:22
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
and whitelist two intentional violations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants