Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refatcor: change timeout to promise #277

Merged
merged 1 commit into from
Sep 7, 2020
Merged

refatcor: change timeout to promise #277

merged 1 commit into from
Sep 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 7, 2020

FC 里时序需要梳理一下,timeout 和 useEffect 冲突导致多个 file 同时上传的时候不是一个稳定状态。这个改完 antd 里还要接着改。

ref ant-design/ant-design#26536

@zombieJ zombieJ requested a review from afc163 September 7, 2020 03:37
@vercel
Copy link

vercel bot commented Sep 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/upload/jxz2hlld7
✅ Preview: https://upload-git-async.react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #277 into master will decrease coverage by 0.09%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   74.05%   73.96%   -0.10%     
==========================================
  Files           6        6              
  Lines         239      242       +3     
  Branches       58       58              
==========================================
+ Hits          177      179       +2     
- Misses         62       63       +1     
Impacted Files Coverage Δ
src/AjaxUploader.tsx 68.70% <37.50%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9cf44...746fc57. Read the comment docs.

@zombieJ zombieJ merged commit 7c7746e into master Sep 7, 2020
@zombieJ zombieJ deleted the async branch September 7, 2020 03:43
@afc163
Copy link
Member

afc163 commented Sep 7, 2020

是不是应该发 minor,和未改动过的 antd 版本配合有没有问题。

@zombieJ
Copy link
Member Author

zombieJ commented Sep 7, 2020

上周重构成 father 发了 3.3.0 ,这个改动对当前版本没有影响。但是对于 ant-design/ant-design#26612 的 fix 有需求。

@afc163
Copy link
Member

afc163 commented Sep 7, 2020

4.6.3 已经依赖了 rc-upload@~3.3.0。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants