-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use dumi #558
feat: use dumi #558
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/table/hvcsybku3 |
@@ -2,8 +2,8 @@ import React from 'react'; | |||
import CSSMotionList from 'rc-animate/lib/CSSMotionList'; | |||
import classNames from 'classnames'; | |||
import toArray from 'rc-util/lib/Children/toArray'; | |||
import Table from '../src'; | |||
import '../assets/index.less'; | |||
import Table from 'rc-table'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
奇了怪了,设了 tsconfig 别名,不生效呢
使用了 dumi 1.0.37 这个 a 标签后面的 icon 感觉有点不好看,所以打算用 样式隐藏掉。 使用 1.1.0-rc4 就报错,rc-table 找不到,但是 rc-field-form https://github.com/react-component/field-form 这个项目使用了 1.1.0-rc4 别名就不报错 真是见鬼了 |
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 26 26
Lines 803 803
Branches 234 234
=======================================
Hits 802 802
Misses 1 1 Continue to review full report at Codecov.
|
import Table from '../src'; | ||
import '../assets/index.less'; | ||
import Table from 'rc-table'; | ||
import '../../assets/index.less'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 assets 用相对路径可以吗?这样的话使用 rc-table
就没意义了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个没想好起啥别名?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里导入写的时候考虑用户会直接 copy 代码可以运行,不然写的那些 rc-table 的别名就全没有意义了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉 除非是 自己引自己 node_modules 才能找到呀
import 'react-resizable/css/styles.css'; | ||
import { ColumnType } from '../src/interface'; | ||
import { ColumnType } from '@/interface'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个用 @ 可以吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsconfig 设的别名,这个可以用。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个会直接展示在代码片段上,用户直接 copy 代码可以用吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { ColumnsType } from '../src/interface'; | ||
import Table from 'rc-table'; | ||
import '../../assets/index.less'; | ||
import { ColumnsType } from '@/interface'; | ||
import { useCheckbox } from './utils/useInput'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 utils 引用路径
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close #557
close #496
close #407
close #383