Be tidier with dependencies and plugins #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncyManagement. This is a minor tidiness point but it also cleans up the dependency lists of the downstream projects: they now explicitly declare all of their deps, rather than just the unusual ones, and don't declare ones they don't use. I've done likewise with plugins: the parent POM has no build step, so having plugins doesn't help it.
rcpoison
added a commit
that referenced
this pull request
Mar 6, 2012
Be tidier with dependencies and plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Littering the parent POM's build with unused dependencies to avoid typing dependency stanzas in modules is a bit dubious. This change pushes the dependencies into a dependencyManagement section (for control of scope and version) and adds explicit dependency lists to all modules.
Likewise littering the parent POM's build with unused plugins. The plugin configurations have been pushed into a pluginManagement section to allow them to apply to modules without modifying the POM-only parent's build.
Consider this a suggestion only. :)