Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI improvements #92

Merged
merged 1 commit into from
Jun 29, 2021
Merged

CI improvements #92

merged 1 commit into from
Jun 29, 2021

Conversation

Margen67
Copy link
Contributor

Add pull_request and workflow_dispatch.
Formatting.
Remove unneeded names from checkout and upload-artifact.
Add cache.
Replace Invoke-WebRequest with curl.
Use Start-Process -Wait instead of Start-Sleep hack: #21

@micwoj92
Copy link
Collaborator

Thanks for contribution. I have couple questions first:

What do you mean by " Remove unneeded names from checkout and upload-artifact."?
What are the benefits of using curl over Invoke-WebRequest?

@Margen67
Copy link
Contributor Author

Thanks for contribution. I have couple questions first:

What do you mean by " Remove unneeded names from checkout and upload-artifact."?

The names are almost the same as the actions so they're redundant.

What are the benefits of using curl over Invoke-WebRequest?

Not having to specify the filename.

@micwoj92
Copy link
Collaborator

micwoj92 commented Jun 28, 2021 •
edited
Loading

Last question:
Autoit currently doesn't version downloads, is it possible to let's say purge cache each (x amount of time) to make sure that latest version of tools is being used?

Then if you resolve conflicts (checksum output was changed) I can merge this.

@micwoj92 micwoj92 added the enhancement New feature or request label Jun 28, 2021
@rcmaehl rcmaehl self-assigned this Jun 28, 2021
@rcmaehl rcmaehl added the awaiting reporter Awaiting response from reporter / submitter label Jun 28, 2021
@Margen67
Copy link
Contributor Author

Last question:
Autoit currently doesn't version downloads, is it possible to let's say purge cache each (x amount of time) to make sure that latest version of tools is being used?

Then if you resolve conflicts (checksum output was changed) I can merge this.

As far as I know the only way of purging the cache is changing the key.

@micwoj92
Copy link
Collaborator

micwoj92 commented Jun 29, 2021 •
edited
Loading

Ah, autoit doesn't have that many releases anyway, so I think that it is fine to manage that manually.

@Margen67
CI improvements
c39952f 
Add pull_request and workflow_dispatch.
Formatting.
Remove unneeded names from checkout and upload-artifact.
Add cache.
Replace Invoke-WebRequest with curl.
Remove unneeded dir.
Use Start-Process -Wait instead of Start-Sleep hack.
Use wildcard for upload-artifact/release.
@micwoj92 micwoj92 merged commit b9e858a into rcmaehl:main Jun 29, 2021
@micwoj92
Copy link
Collaborator

Thank you for your contribution!

@micwoj92
Copy link
Collaborator

micwoj92 commented Jun 29, 2021 •
edited
Loading

hmm, it complains about au3stripper.dat missing, even on your repo
https://github.com/Margen67/WhyNotWin11/runs/2937413633?check_suite_focus=true#step:6:17

@micwoj92
Copy link
Collaborator

I don't think it is critical issue, but if it can't be resolved then I will have to delete cache step which I suspect is the issue (but I might be wrong)

@micwoj92 micwoj92 removed the awaiting reporter Awaiting response from reporter / submitter label Jun 29, 2021
@Margen67 Margen67 deleted the actions branch June 29, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rcmaehl rcmaehl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Margen67 @micwoj92 @rcmaehl