Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 040D.lang #298

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Update 040D.lang #298

merged 2 commits into from
Jul 1, 2021

Conversation

dinuto
Copy link
Contributor

@dinuto dinuto commented Jun 30, 2021

No description provided.

@micwoj92
Copy link
Collaborator

@HypeGameMode do you approve?

@TheScoreFan
Copy link
Contributor

About the language fix, Yes I approve.
But I see you added an hebrew translation where I didn't put, and I will tell you why I didn't put. for here example:
64 Bit CPU=64 Bit CPU
64 Bit OS=64 Bit OS
32 Bit CPU=32 Bit CPU
32 Bit OS=32 Bit OS

Because here if i will put hebrew it will make issues with rtl and will not be easy to read on hebrew, This is why I suggest to leave there on English language
Another example where you put hebrew with english which cause the same issue
DirectX 12 and WDDM 3=DirectX 12 ו-WDDM 3
DirectX 12 and WDDM 2=DirectX 12 ו-WDDM 2
Because English is left to right language and hebrew is right to left language it can be very mess when you combine these 2 languages in the same line, sometimes you can do it good, but sometimes it can be mess
But except for that I approve

@dinuto
Copy link
Contributor Author

dinuto commented Jun 30, 2021

ohh I see...
well it can be done right, but I guess if it will ever be implemented it will be part of a complete RTL support for this app.

However, I think if a sentence starts with Hebrew and then continues with English it should be fine, and there are proofs for that in the current translation, for example, TPM גרס and Windows 11 התוצאות מבוססות על גבי הדרישות הנוכחיות של looks fine,
so i think only the parts when a sentence starts with English and continue with Hebrew may be problematic. I will revert these changes.

Langs/040D.lang Outdated Show resolved Hide resolved
@micwoj92
Copy link
Collaborator

All seems good now? Will be merged if yes

@TheScoreFan
Copy link
Contributor

Yes

@micwoj92 micwoj92 merged commit 1052a39 into rcmaehl:main Jul 1, 2021
@dinuto dinuto deleted the patch-1 branch July 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants