Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Remove genesis from conflict set. #3809

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Bugfix. Remove genesis from conflict set. #3809

merged 1 commit into from
Aug 30, 2022

Conversation

nzpr
Copy link
Collaborator

@nzpr nzpr commented Aug 29, 2022

Overview

Closes #3804. Dumb mistake of mine lead to investigation of a rabbit hole of a descent size. The problem was that genesis has been merged into its post state in the very beginning of the network. After this change now network of 5 nodes seems ok and reach block #6200 now.

Notes

Please make sure that this PR:

Bors cheat-sheet:

  • bors r+ runs integration tests and merges the PR (if it's approved),
  • bors try runs integration tests for the PR,
  • bors delegate+ enables non-maintainer PR authors to run the above.

@nzpr nzpr mentioned this pull request Aug 29, 2022
5 tasks
@nzpr nzpr added the bug-fix label Aug 29, 2022
@nzpr nzpr added this to the Block merge (Hard Fork 2) milestone Aug 29, 2022
Copy link
Collaborator

@stanislavlyalin stanislavlyalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Copy link
Collaborator

@tgrospic tgrospic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch!! 🥳

@nzpr
Copy link
Collaborator Author

nzpr commented Aug 29, 2022

bors merge

bors bot added a commit that referenced this pull request Aug 29, 2022
3809: Bugfix. Remove genesis from conflict set. r=nzpr a=nzpr



Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2022

Build failed:

@nzpr
Copy link
Collaborator Author

nzpr commented Aug 29, 2022

bors merge

bors bot added a commit that referenced this pull request Aug 29, 2022
3809: Bugfix. Remove genesis from conflict set. r=nzpr a=nzpr



Co-authored-by: nutzipper <1746367+nzpr@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2022

Build failed:

@nzpr
Copy link
Collaborator Author

nzpr commented Aug 30, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Build succeeded:

@bors bors bot merged commit fd537b8 into rchain:dev Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to consume results of system deploy investigation.
3 participants