Support for .ruby-version files #302
Conversation
|
Thanks Sam, this looks really good. I'm really happy to see Given the backwards compatibility of detecting either dot file, would you see this requiring a minor version bump if and when it's released? |
|
Glad you're on board, @fnichol! This is the last remaining issue before we release rbenv 0.4.0 (this week, assuming no major blockers). We will maintain backwards compatibility with existing |
|
Looks good! The only issue I see here is that |
|
@mislav It's by design. I'm open to reconsidering if you feel strongly about it, but I wanted to focus strictly on |
| @@ -13,10 +13,18 @@ if [ -z "$RBENV_VERSION" ] || [ "$RBENV_VERSION" = "system" ]; then | |||
| exit | |||
| fi | |||
|
|
|||
| RBENV_VERSION_PATH="${RBENV_ROOT}/versions/${RBENV_VERSION}" | |||
| version_exists() { | |||
| local version="$1" | |||
There was a problem hiding this comment.
Since Bash lacks named function arguments, I tend to explicitly assign them to local variables for clarity.
|
👍 @sstephenson any estimate on a release for this? It looks like it's all that's remaining for |
|
This is cool, but I can't find an argument for making the change. What makes this change desirable? Just want to rename the file for clarity? |
|
@parkr compatibility with other ruby version managers (rvm, chruby, ...) |
|
@guilleiguaran @sethvargo Thanks! Just found that link after looking through a couple more issues here. A common ruby-version file will be nice. Thanks for the help in understanding, guys. |
Support for .ruby-version files
|
🎉 |
|
❤️ 👍 |
Support for .ruby-version files
This branch adds support for per-project
.ruby-versionfiles.rbenv treats
.ruby-versionfiles the same way as it has always treated.rbenv-versionfiles. A version specified in a.ruby-versionfile maps directly to a directory in$RBENV_ROOT/versions, without fuzzy version matching or other preprocessing (but with additional consideration for version names beginning withruby-, as described below)..ruby-versionbecomes the preferred file for storing local version specifications. Therbenv version-filecommand now prefers.ruby-versionfiles when searching up the working directory tree. rbenv will still read versions specified in.rbenv-versionif a.ruby-versionfile is not present.Setting the local version with
rbenv localnow writes a.ruby-versionfile. If the local version was previously specified by.rbenv-version, rbenv will remove it and print a migration notice to stderr.For compatibility with other version managers, if the version specification begins with
ruby-but does not match a directory in$RBENV_ROOT/versions, rbenv will try to match it by removing theruby-prefix. If a match is found, rbenv accepts it but prints a warning to stderr./cc @mislav @jeremy