[Core] fail to download s3 py modules #49332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xie Yifan <yifan.xie@shopee.com>
laysfire
changed the title
| @@ -784,7 +785,20 @@ async def download_and_unpack_package( | |||
| "`pip install boto3` to fetch URIs in s3 " | |||
| "bucket. " + install_warning | |||
| ) | |||
| tp = {"client": boto3.client("s3")} | |||
| s3_kwargs = {} | |||
There was a problem hiding this comment.
Hey @laysfire , not a ray maintainer but I will suggest adding a test case for your change.
|
@laysfire I have already assigned my colleagues to review this PR. Would you mind fixing the conflicts? |
dentiny
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Several things:
- Code change looks ok to me
- This is an interface change, you need to document two new env vars: https://github.com/ray-project/ray/blob/master/doc/source/ray-core/handling-dependencies.rst#api-reference
- @rynewang / @jjyao Do we have security concern on storing key directly in text format in env?
jjyao
reviewed
Dec 31, 2024
| s3_kwargs["aws_secret_access_key"] = env_vars[ | ||
| "AWS_SECRET_ACCESS_KEY" | ||
| ] | ||
| tp = {"client": boto3.client("s3", **s3_kwargs)} |
There was a problem hiding this comment.
Per https://boto3.amazonaws.com/v1/documentation/api/latest/guide/quickstart.html, we can save credentials to ~/.aws/credentials and everything should work?
|
LGTM, @jjyao any concerns? |
Is there any other solutions? At least we should update the doc to mention this approach otherwise no one will know it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In our scenario, the users would upload working dir or py modules to s3 and submit job with filling security credential in runtime env.
Currently Ray doesn't support fetch security credential information from user runtime env, so the job would fail when download s3 resources.
This PR is to fix this issue.
Related issue number
None
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.