[Core] Move submitting actor creation task to ActorTaskSubmitter #47080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
rynewang
reviewed
Aug 12, 2024
| resolver_.ResolveDependencies(task_spec, [this, task_spec](Status status) mutable { | ||
| // NOTE: task_spec here is capture copied (from a stack variable) and also | ||
| // mutable. (Mutations to the variable are expected to be shared inside and | ||
| // outside of this closure). |
There was a problem hiding this comment.
I think it's sharing the mutations because the underlying is a shared_ptr. If it's a regular class it's copied and outside of the closure we won't see it.
rynewang
approved these changes
Aug 12, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a pure refactor. After this PR, ActorTaskSubmitter is responsible for actor related tasks and NormalTaskSubmitter is responsible for normal tasks.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.