[Serve] Patching ActorProxyWrapper to properly handle is_drained RPC #41755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#41744) This is a minified version of https://github.com/ray-project/ray/pull/41722/files, specifically put to be cherry-picked into 2.9 Addresses #41726 --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
alexeykudinkin
changed the title
567e5744b255899d54f5b048646e4bd4caf64fc0 to 2.9 branch567e5744b255899d54f5b048646e4bd4caf64fc0 to 2.9 branch
edoakes
approved these changes
Dec 8, 2023
zhe-thoughts
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Approved. But @alexeykudinkin do you think you can fix the PR title? Or there's a reason to use the full hash?
alexeykudinkin
changed the title
567e5744b255899d54f5b048646e4bd4caf64fc0 to 2.9 branch567e5744 to 2.9 branch
|
@zhe-thoughts shortened it. Should i just replicate the title from the original one? |
alexeykudinkin
changed the title
567e5744 to 2.9 branch
|
Updated title/description |
|
@alexeykudinkin this works, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a minified version of https://github.com/ray-project/ray/pull/41722/files, specifically put to be cherry-picked into 2.9
Addresses #41726
Addresses following gaps:
ActorProxyWrapper.is_drainedmethod to handle RPC response properlyProxyStateto fix draining sequence #41722 to validate draining sequence is correctChecks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.