[ci] always update apt in dashboard tests #41754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Dec 8, 2023
aslonnie
approved these changes
Dec 8, 2023
dashboard/tests/run_ui_tests.sh
Outdated
| @@ -12,6 +12,7 @@ trap clean_up EXIT | |||
|
|
|||
| echo "Installing cypress" | |||
| if [ -n "$BUILDKITE" ]; then | |||
| sudo apt-get update | |||
There was a problem hiding this comment.
could you also change the next line of apt install into apt-get install?
and add sudo (or remove all sudos) for consistency?
can-anyscale
force-pushed
the
can-fix-dashboard
branch
4 times, most recently
from
0f85f69 to
57a0274
Compare
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-fix-dashboard
branch
from
57a0274 to
22d3fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, the test might fail if apt has been cached and not updated. Currently blocking release branch https://buildkite.com/ray-project/postmerge/builds/2005#018c4a89-ec04-4f3b-83de-744b6e85fe63/159-895
Test: