Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Update serve.start API from system_logging_config to logging_config #41749

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[Serve] Update serve.start API from system_logging_config to logging_config #41749

merged 1 commit into from
Dec 8, 2023

Conversation

sihanwang41
Copy link
Contributor

@sihanwang41 sihanwang41 commented Dec 8, 2023 •
edited
Loading

Why are these changes needed?

Currently we have mismatch api logging_config and system_logging_config, change system_logging_config to logging_config to reduce the confusion since it will be applied to application & deployment too.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sihanwang41
[Serve] Update system_logging_config to logging_config
2daad18 
Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
@sihanwang41 sihanwang41 changed the title [Serve] Update system_logging_config to logging_config [Serve] Update serve.start API from system_logging_config to logging_config Dec 8, 2023
GeneDer
GeneDer approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes edoakes merged commit d6d2689 into ray-project:master Dec 8, 2023
10 of 15 checks passed
sihanwang41 added a commit to sihanwang41/ray that referenced this pull request Dec 8, 2023
@sihanwang41
[Serve] Update system_logging_config to logging_config (ray-project#4…
7b3cfb1 
…1749)

Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
@sihanwang41 sihanwang41 mentioned this pull request Dec 8, 2023
Merged
8 tasks
architkulkarni pushed a commit that referenced this pull request Dec 12, 2023
@sihanwang41 @edoakes
[Serve] Update system_logging_config to logging_config (#41749) (#41757)
ce8f82f 
cherrypick: #41749

we have an api inconsistency in the logging config.

Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@GeneDer GeneDer GeneDer approved these changes

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sihanwang41 @GeneDer @edoakes