Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][serve] Fix subsection title hierarchy #41746

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[docs][serve] Fix subsection title hierarchy #41746

merged 1 commit into from
Dec 8, 2023

Conversation

angelinalg
Copy link
Contributor

Subsections are appearing in the Serve Examples page as separate docs vs sections of the Streaming doc.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@angelinalg
[docs][serve] Fix subsection title hierarchy
ea9b5c0 
Subsections are appearing in the Serve Examples page as separate docs vs sections of the Streaming doc.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
shrekris-anyscale
shrekris-anyscale approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@edoakes edoakes merged commit aa86ef6 into master Dec 8, 2023
6 of 10 checks passed
@edoakes edoakes deleted the angelinalg-patch-2 branch December 8, 2023 20:15
angelinalg added a commit to angelinalg/ray that referenced this pull request Dec 8, 2023
@angelinalg
[docs][serve] Fix subsection title hierarchy (ray-project#41746)
b397c96 
Subsections are appearing in the Serve Examples page as separate docs vs sections of the Streaming doc.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg added serve Ray Serve Related Issue docs An issue or change related to documentation v2.9.0-pick labels Dec 8, 2023
@angelinalg angelinalg mentioned this pull request Dec 8, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

@edoakes edoakes edoakes approved these changes

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

@zcin zcin Awaiting requested review from zcin zcin is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees
No one assigned
Labels
docs An issue or change related to documentation serve Ray Serve Related Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelinalg @edoakes @shrekris-anyscale