[Serve] Patching ActorProxyWrapper to properly handle is_drained RPC
#41744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
alexeykudinkin
added
ray 2.9
edoakes
reviewed
Dec 8, 2023
Comment on lines
+829
to
+830
| # assert proxy_state._actor_proxy_wrapper.get_num_health_checks() == 10 | ||
| # assert proxy_state._actor_proxy_wrapper.get_num_drain_checks() == 9 |
There was a problem hiding this comment.
intentionally commented out?
There was a problem hiding this comment.
+1 on those commented out code
There was a problem hiding this comment.
Yes, forgot to remove, asserting on these is currently meaningless unfortunately.
I'm planning to supersede this by https://github.com/ray-project/ray/pull/41722/files
| if is_drained: | ||
| return ProxyWrapperCallStatus.FINISHED_SUCCEED | ||
| else: | ||
| # NOTE: Even though call returned successfully, we have to |
There was a problem hiding this comment.
please update the docstring above to match this
There was a problem hiding this comment.
Not sure if there's much value since this is just a temporary cherry-pick and it's gonna be replaced by https://github.com/ray-project/ray/pull/41722/files anyway
GeneDer
approved these changes
Dec 8, 2023
Comment on lines
+829
to
+830
| # assert proxy_state._actor_proxy_wrapper.get_num_health_checks() == 10 | ||
| # assert proxy_state._actor_proxy_wrapper.get_num_drain_checks() == 9 |
There was a problem hiding this comment.
+1 on those commented out code
alexeykudinkin
added a commit
that referenced
this pull request
Dec 8, 2023
#41744) This is a minified version of https://github.com/ray-project/ray/pull/41722/files, specifically put to be cherry-picked into 2.9 Addresses #41726 --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
8 tasks
architkulkarni
pushed a commit
that referenced
this pull request
Dec 11, 2023
#41744) (#41755) This is a minified version of https://github.com/ray-project/ray/pull/41722/files, specifically put to be cherry-picked into 2.9 Addresses #41726 Addresses following gaps: Patches ActorProxyWrapper.is_drained method to handle RPC response properly Cherry-picks a test from [Serve] Revisiting ProxyState to fix draining sequence #41722 to validate draining sequence is correct --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minified version of https://github.com/ray-project/ray/pull/41722/files, specifically put to be cherry-picked into 2.9
Addresses #41726
Addresses following gaps:
ActorProxyWrapper.is_drainedmethod to handle RPC response properlyProxyStateto fix draining sequence #41722 to validate draining sequence is correctChecks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.