[Core] Speed up single_client_tasks_sync #41743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
|
Microbenchmark: https://buildkite.com/ray-project/release/builds/3607#018c4af2-38cb-468f-9403-f6bc9cccd1db single_client_tasks_sync = [1028.731851730263, 6.294947883118997] |
rickyyx
reviewed
Dec 8, 2023
| ) | ||
| except AttributeError: | ||
| # Lazy initialization. | ||
| resource_name_to_accelerator_manager = { |
There was a problem hiding this comment.
oh this gets cache across invocation? i thought function doesn't have attribute cached like this.
There was a problem hiding this comment.
Yes, this basically implements function static variable in C++.
rickyyx
approved these changes
Dec 9, 2023
jjyao
added a commit
that referenced
this pull request
Dec 9, 2023
--------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
architkulkarni
pushed a commit
that referenced
this pull request
Dec 12, 2023
Currently IntelGPUAcceleratorManager.get_current_node_num_accelerators() will be called everytime we try to get accelerator manager for GPU resource. This is expensive and makes single_client_tasks_sync slower. This PR changes to only call it once. Related issue number #41695 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently
IntelGPUAcceleratorManager.get_current_node_num_accelerators()will be called everytime we try to get accelerator manager for GPU resource. This is expensive and makessingle_client_tasks_syncslower. This PR changes to only call it once.Related issue number
#41695
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.