[serve] Update replica ID format (and other random strings) to better match UUIDs #41737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
commented
Dec 8, 2023
| @@ -614,7 +614,7 @@ def shutdown(self): | |||
| and proxy_state_is_shutdown | |||
| ): | |||
| logger.warning( | |||
| "All resources have shut down, shutting down controller!", | |||
There was a problem hiding this comment.
@GeneDer reminder to mostly avoid exclamation points in log messages (and other technical writing)
GeneDer
approved these changes
Dec 8, 2023
| def get_random_letters(length=6): | ||
| return "".join(random.choices(string.ascii_letters, k=length)) | ||
| # Match the standard alphabet used for UUIDs. | ||
| RANDOM_STRING_ALPHABET = string.ascii_lowercase + string.digits |
There was a problem hiding this comment.
Non-blocker: A bit nit, since we now allows digits, maybe can name it RANDOM_STRING_ALPHANUMERIC instead? 🙃
There was a problem hiding this comment.
Also kinda after thought, there is also a UUID module in python not sure if we want to consider using that
There was a problem hiding this comment.
yes we use UUID elsewhere but here the length of the UUID is overkill and will degrade the UX for reading logs (replica IDs are scoped to a single deployment in a single cluster)
sihanwang41
approved these changes
Dec 8, 2023
shrekris-anyscale
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Small cosmetic update to our replica ID generation to make it use the same alphabet as
UUID(which is standard and we use for request IDs).Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.