[Core] Fix check failure when sync and async tasks are mixed up #41724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2023 15:31
jjyao
approved these changes
Dec 8, 2023
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Dec 15, 2023
…project#41724) When sync and async tasks are mixed up, there are sometimes where TaskID is not correctly set, which causes the check failure. This is the case where check failure correctly found a bug. I fixed the issue by passing TaskID correctly. Also improved get_current_task_id API to always return the correct task ID when used within raylet.pyx
architkulkarni
pushed a commit
that referenced
this pull request
Dec 15, 2023
…) (#41946) When sync and async tasks are mixed up, there are sometimes where TaskID is not correctly set, which causes the check failure. This is the case where check failure correctly found a bug. I fixed the issue by passing TaskID correctly. Also improved get_current_task_id API to always return the correct task ID when used within raylet.pyx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When sync and async tasks are mixed up, there are sometimes where TaskID is not correctly set, which causes the check failure. This is the case where check failure correctly found a bug.
I fixed the issue by passing TaskID correctly. Also improved
get_current_task_idAPI to always return the correct task ID when used within raylet.pyxRelated issue number
Closes #41346
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.