[serve] migrate serve ha integration test to civ2 #41713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-1207-serveha
branch
from
e574190 to
7c55118
Compare
can-anyscale
approved these changes
Dec 8, 2023
| instance_type: medium | ||
| commands: | ||
| - bazel run //ci/ray_ci:build_in_docker -- docker --python-version 3.8 --platform cpu --canonical-tag ha_integration | ||
| - docker tag rayproject/ray:ha_integration ray_ci:v1 |
There was a problem hiding this comment.
where is the ray_ci:v1 tag is defined? maybe just us the same name overthere and remove this line?
There was a problem hiding this comment.
it is in the python/ray/tests/conftest.py. I can do it as a follow up (and cleanup the old prepare_docker() function entirely.
|
@edoakes , before this change, |
aslonnie
commented
Dec 8, 2023
| [ | ||
| "RAY_CI_SERVE_AFFECTED", | ||
| "RAY_CI_PYTHON_AFFECTED", | ||
| "RAY_CI_ML_AFFECTED", |
There was a problem hiding this comment.
I removed the ml tag. or the dependency of jobs would look a bit weird.
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-1207-serveha
branch
from
8d37643 to
1501b4c
Compare
|
test passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and rename
xcommittag toha_integration