Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Deflake gcs_placement_group_manager_test #41710

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Dec 7, 2023

Why are these changes needed?

Another attempt after #30787. The root cause is that gcs_placement_group_manager is supposed to be single threaded but our test creates two threads (main thread and the io thread) and causes race conditions. The fix is removing one thread and run the io context in the main thread.

Related issue number

Closes #41215

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from a team as a code owner December 7, 2023 22:33
@jjyao jjyao merged commit 959a48b into ray-project:master Dec 8, 2023
3 checks passed
@jjyao jjyao deleted the jjyao/flaky branch December 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] linux://:gcs_placement_group_manager_test is failing/flaky on master.
2 participants