Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Clean the dev env after build wheels for macOS #41694

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

jiwq
Copy link
Contributor

@jiwq jiwq commented Dec 7, 2023

Why are these changes needed?

When we execute ./python/build-wheel-macos.sh to build the wheels, this script created some conda envs (such as py3.8 etc.) and use it to build wheels. But these envs were not removed which broken the developer's dev env. So I recommend to clean the dev env after build wheels for macOS.

Related issue number

Closes #41662

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

jiwq and others added 3 commits December 8, 2023 00:04
Signed-off-by: Wanqiang Ji <me@jiwq.cn>
Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
@aslonnie aslonnie self-requested a review December 8, 2023 04:34
@aslonnie aslonnie self-assigned this Dec 8, 2023
@aslonnie aslonnie merged commit b71e1c3 into ray-project:master Dec 9, 2023
13 of 15 checks passed
@jiwq jiwq deleted the ci branch December 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Clean the dev env after build wheels for macOS
2 participants