Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] [data] remove Data Processing tag from sidenav and examples #41686

Merged
merged 5 commits into from
Dec 8, 2023
Merged

[docs] [data] remove Data Processing tag from sidenav and examples #41686

merged 5 commits into from
Dec 8, 2023

Conversation

angelinalg
Copy link
Contributor

After much discussion, the Data Processing tag is too general. Removing it from the Example Gallery.
cc: @amogkam @scottjlee @pcmoritz

Related issue number

Closes #41607.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@angelinalg
remove Data Processing tag from sidenav and examples
0906d01 
Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg requested a review from a team as a code owner December 7, 2023 01:01
@peytondmurray peytondmurray mentioned this pull request Dec 7, 2023
Merged
8 tasks
peytondmurray
peytondmurray reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also make sense to remove the data-processing tag everywhere in examples.rst?

@angelinalg
Copy link
Contributor Author

Good question, @peytondmurray. Yes, I removed that tag from the examples.rst file in another PR. You should be able to verify that in master.

@pcmoritz pcmoritz merged commit 563f7d8 into ray-project:master Dec 8, 2023
9 of 10 checks passed
angelinalg added a commit to angelinalg/ray that referenced this pull request Dec 8, 2023
@angelinalg
[docs] [data] remove Data Processing tag from sidenav and examples (r…
fd5af55 
…ay-project#41686)

After much discussion, the Data Processing tag is too general. Removing it from the Example Gallery.
cc: @amogkam @scottjlee @pcmoritz

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
@angelinalg angelinalg deleted the remove-data-processing-tag branch December 8, 2023 20:57
@angelinalg angelinalg added docs An issue or change related to documentation data Ray Data-related issues v2.9.0-pick labels Dec 8, 2023
@angelinalg angelinalg mentioned this pull request Dec 8, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray left review comments

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
data Ray Data-related issues docs An issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][data] Remove Data Processing filter button from the sidebar in the Example Gallery
3 participants
@angelinalg @pcmoritz @peytondmurray