[Core] Fix core worker client pool leak #41535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
commented
Dec 3, 2023
| @@ -781,6 +781,8 @@ RAY_CONFIG(int64_t, grpc_client_keepalive_time_ms, 300000) | |||
| /// grpc keepalive timeout for client. | |||
| RAY_CONFIG(int64_t, grpc_client_keepalive_timeout_ms, 120000) | |||
|
|
|||
| RAY_CONFIG(int64_t, grpc_client_idle_timeout_ms, 1800000) | |||
There was a problem hiding this comment.
This is the grpc default value: 30 minutes.
rkooo567
reviewed
Dec 6, 2023
| /// Also see https://grpc.github.io/grpc/core/md_doc_connectivity-semantics-and-api.html | ||
| /// for channel connectivity state machine. | ||
| bool IsChannelIdleAfterRPCs() const { | ||
| return (channel_->GetState(false) == GRPC_CHANNEL_IDLE) && call_method_invoked_; |
There was a problem hiding this comment.
GetState is not blocking right?
| auto id = WorkerID::FromBinary(addr_proto.worker_id()); | ||
| auto it = client_map_.find(id); | ||
| if (it != client_map_.end()) { | ||
| return it->second; | ||
| entry = *it->second; | ||
| client_list_.erase(it->second); |
There was a problem hiding this comment.
Isn't this actually pretty expensive (O(N)) if there are lots of connections?
There was a problem hiding this comment.
Why don't we just make RemoveIdleClients called every 30 seconds or something instead
?
There was a problem hiding this comment.
std::list is doubly linked list so it's constant time.
rkooo567
added
the
@author-action-required
rkooo567
approved these changes
Dec 8, 2023
|
Hello, am I understanding correctly that this fix is not yet merged into any release? Thanks |
|
@m-harmonic Yes, it will be part of Ray 2.10 release. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently core worker client pool doesn't remove clients in most cases (there are one or two places where
Disconnect()might be called) and this caused memory leak. This PR adds a GC inside core worker client pool to remove IDLE clients (i.e.g clients that don't have active connections).Related issue number
Closes #41260
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.