-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] arm64 wheels #41056
[ci] arm64 wheels #41056
Conversation
818751c
to
c6e7951
Compare
.buildkite/build.rayci.yml
Outdated
depends_on: manylinux-x86_64 | ||
job_env: manylinux-x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the extra spaces?
.buildkite/_forge.rayci.yml
Outdated
wanda: ci/docker/forge.aarch64.wanda.yaml | ||
instance_type: builder-arm64 | ||
|
||
- name: manylinux-x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep this as manylinux
? and just add the other one? maybe just make a copy of the wanda file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep them explicit on purpose to avoid having to deal with them down the line with if-else like; having special naming for default cases is pretty troublesome
if arch == DEFAULT:
docker = manylinux
else:
docker = f"manylinux-{arch}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline, decided to drop the suffix. most of the ci/cd runs as x86_64
today. if we add the suffix, we probably should add suffix to everything..
in the long term, if aarch64
has more usage, the ci/cd toolchain/platform can handle this seemlessly (at rayci/wanda level)
4d619fd
to
7cd82f8
Compare
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
7cd82f8
to
5292978
Compare
Build arm64 wheels in civ2 Signed-off-by: can <can@anyscale.com>
Build arm64 wheels
Test: