Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] arm64 wheels #41056

Merged
merged 2 commits into from
Nov 14, 2023
Merged

[ci] arm64 wheels #41056

merged 2 commits into from
Nov 14, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Nov 9, 2023

Build arm64 wheels

Test:

  • CI

@can-anyscale can-anyscale force-pushed the can-civ-03 branch 11 times, most recently from 818751c to c6e7951 Compare November 10, 2023 04:02
@can-anyscale can-anyscale marked this pull request as ready for review November 13, 2023 15:16
@can-anyscale can-anyscale requested a review from a team November 13, 2023 15:16
Comment on lines 58 to 59
depends_on: manylinux-x86_64
job_env: manylinux-x86_64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the extra spaces?

wanda: ci/docker/forge.aarch64.wanda.yaml
instance_type: builder-arm64

- name: manylinux-x86_64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this as manylinux? and just add the other one? maybe just make a copy of the wanda file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep them explicit on purpose to avoid having to deal with them down the line with if-else like; having special naming for default cases is pretty troublesome

if arch == DEFAULT:
docker = manylinux
else:
docker = f"manylinux-{arch}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, decided to drop the suffix. most of the ci/cd runs as x86_64 today. if we add the suffix, we probably should add suffix to everything..

in the long term, if aarch64 has more usage, the ci/cd toolchain/platform can handle this seemlessly (at rayci/wanda level)

@can-anyscale can-anyscale force-pushed the can-civ-03 branch 2 times, most recently from 4d619fd to 7cd82f8 Compare November 13, 2023 20:11
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale merged commit 330cae6 into master Nov 14, 2023
2 checks passed
@can-anyscale can-anyscale deleted the can-civ-03 branch November 14, 2023 00:29
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Build arm64 wheels in civ2

Signed-off-by: can <can@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants