[Core] Auto generate protobuf and grpc code #40663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
commented
Oct 25, 2023
Comment on lines
+307
to
+309
| repo_mapping = { | ||
| "@com_google_protobuf": "@com_google_protobuf_rules_proto_grpc", | ||
| }, |
There was a problem hiding this comment.
This is the key change.
jjyao
commented
Oct 25, 2023
| sed -i -E 's/from ..experimental/from ./' "$${autoscale_files[@]}" | ||
| echo "$${PWD}" > $@ | ||
| """, | ||
| local = 1, |
There was a problem hiding this comment.
@aslonnie mentioned that it's not best practice of using bazel. Will have a follow-up PR to fix it.
There was a problem hiding this comment.
Will have a follow-up PR to fix it.
hmm... when?
There was a problem hiding this comment.
If you think it's important, I'll do it right after this one is merged.
fishbone
approved these changes
Oct 25, 2023
edoakes
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Revert back to the old way (before #39210) of auto-generating protobuf and grpc code so we don't need to manually generate and check them in. Also decouple the protobuf version we use in c++ and the protobuf version we use to auto generate python and java code (the protobuf version to auto generate python code affects the python protobuf library version that Ray can support) so that they can be upgraded independently.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.