Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add .whl and serve generated files to .gitignore #40206

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

jiwq
Copy link
Contributor

@jiwq jiwq commented Oct 8, 2023

Why are these changes needed?

  1. The .whl folder that created by build wheel scripts should be ignored. Example: exec ./python/build-wheel-macos.sh
  2. All serve generated files should be ignored. [Not Reproduced 😧 Nov 30 2023]
image

Related issue number

Small fix

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jiwq jiwq changed the title [build] Add .whl and serve generated files to .gitignore [CI] Add .whl and serve generated files to .gitignore Nov 22, 2023
@kevin85421
Copy link
Member

cc @anyscalesam Do you know who would be the best person to review this PR? @jiwq has just followed up with me.

@anyscalesam
Copy link
Contributor

@can-anyscale @aslonnie can y'all take a look

.gitignore Outdated
@@ -11,11 +11,12 @@
/python/build
/python/dist
/python/python-driver-*
/python/ray/serve/generated
/python/ray/serve/generated/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should not be required. I cannot reproduce the untracked files of the *-E files that is shown in your screenshot.

what operating system are you using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used macOS Sonoma and the build environment created by conda which version is 23.1.0. It annoys me before commit the changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what architecture? and git version?

this is what happens on my mac on master branch HEAD:

$ touch python/ray/serve/generated/serve_pb2.py-E
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

the entire generated directory should be ignored, not only files.

I still do not understand why this line change is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same problem and don't understand why. 😧 The bad news is that I haven't reproduced, but I want to try in another machine and give more info. 💪

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce 😧 , so I reset this changed and keep .whl.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is an issue on the 2.8.0 release branch, and has been fixed on master already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't found the related patch 😧

.gitignore Outdated Show resolved Hide resolved
@jiwq
Copy link
Contributor Author

jiwq commented Nov 29, 2023

🤝 Thanks @kevin85421 and @anyscalesam help to ping the relative maintainer.

.gitignore Outdated Show resolved Hide resolved
Exec `./python/build-wheel-macos.sh` will create the `.whl` folder,
it will bother newbies and not friendly to developer.

Signed-off-by: Wanqiang Ji <me@jiwq.cn>
@aslonnie
Copy link
Collaborator

aslonnie commented Dec 2, 2023

fyi, you do not need to worry about merging the PR. I will squash and merge it for you.

@aslonnie aslonnie self-requested a review December 8, 2023 04:34
@aslonnie aslonnie self-assigned this Dec 8, 2023
@aslonnie aslonnie merged commit 7e52a25 into ray-project:master Dec 8, 2023
11 of 15 checks passed
@jiwq jiwq deleted the gitignore branch December 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants