-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add .whl
and serve generated files to .gitignore
#40206
Conversation
.whl
and serve generated files to .gitignore
.whl
and serve generated files to .gitignore
cc @anyscalesam Do you know who would be the best person to review this PR? @jiwq has just followed up with me. |
@can-anyscale @aslonnie can y'all take a look |
.gitignore
Outdated
@@ -11,11 +11,12 @@ | |||
/python/build | |||
/python/dist | |||
/python/python-driver-* | |||
/python/ray/serve/generated | |||
/python/ray/serve/generated/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change should not be required. I cannot reproduce the untracked files of the *-E
files that is shown in your screenshot.
what operating system are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used macOS Sonoma and the build environment created by conda which version is 23.1.0. It annoys me before commit the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what architecture? and git version?
this is what happens on my mac on master branch HEAD:
$ touch python/ray/serve/generated/serve_pb2.py-E
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
the entire generated
directory should be ignored, not only files.
I still do not understand why this line change is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same problem and don't understand why. 😧 The bad news is that I haven't reproduced, but I want to try in another machine and give more info. 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce 😧 , so I reset this changed and keep .whl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is an issue on the 2.8.0 release branch, and has been fixed on master already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't found the related patch 😧
🤝 Thanks @kevin85421 and @anyscalesam help to ping the relative maintainer. |
Exec `./python/build-wheel-macos.sh` will create the `.whl` folder, it will bother newbies and not friendly to developer. Signed-off-by: Wanqiang Ji <me@jiwq.cn>
fyi, you do not need to worry about merging the PR. I will squash and merge it for you. |
Why are these changes needed?
./python/build-wheel-macos.sh
Related issue number
Small fix
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.