[civ2][docker/2] build all ray+ray-ml cuda docker images in civ2 #40139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-docker
branch
from
d53db10 to
776e44d
Compare
can-anyscale
force-pushed
the
can-docker-01
branch
from
9657dfb to
2a99192
Compare
can-anyscale
force-pushed
the
can-docker
branch
3 times, most recently
from
25c072d to
4bef49e
Compare
can-anyscale
force-pushed
the
can-docker-01
branch
from
2a99192 to
3f94923
Compare
can-anyscale
force-pushed
the
can-docker
branch
7 times, most recently
from
6c05adb to
b000a00
Compare
can-anyscale
changed the title
aslonnie
reviewed
Oct 5, 2023
Comment on lines
+62
to
+66
| def get_platform_tag(self) -> str: | ||
| if self.platform == "cpu": | ||
| return "-cpu" | ||
| versions = self.platform.split(".") | ||
| return f"-{versions[0]}{versions[1]}" # cu11.8.0 -> cu118 |
There was a problem hiding this comment.
(lonnie bot speaking) add unit test for this function?
can-anyscale
force-pushed
the
can-docker
branch
from
b000a00 to
13d0da0
Compare
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-docker
branch
from
13d0da0 to
6dbadac
Compare
Zandew
pushed a commit
to Zandew/ray
that referenced
this pull request
Oct 10, 2023
…-project#40139) Now that wanda supports matrix, we can build all ray+ray-ml cuda docker images in civ2. Signed-off-by: can <can@anyscale.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…-project#40139) Now that wanda supports matrix, we can build all ray+ray-ml cuda docker images in civ2. Signed-off-by: can <can@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that wanda supports matrix, we can build all ray+ray-ml cuda docker images in civ2.
Test: