Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[civ2][docker/6] upload ray and ray-ml image in civ2 #39376

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Sep 7, 2023

Upload ray and ray-ml image for py38 and cu118 in civ2. Remove those two flavors in civ1 (which will also removes the uploading of base-deps and ray-deps)

Test:

@can-anyscale can-anyscale force-pushed the can-dev-06 branch 3 times, most recently from d22db7f to bcdde46 Compare September 7, 2023 08:24
@@ -88,6 +88,22 @@ RUN sudo apt-get update -y && sudo apt-get upgrade -y \
else sudo apt-get autoremove -y wget; \
fi;) \
&& sudo rm -rf /var/lib/apt/lists/* \
&& sudo apt-get clean
&& sudo apt-get clean \
&& (if [ "$AUTOSCALER" = "autoscaler" ]; \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move autoscaler library dependencies here so we can get rid of the ray-deps layer

@can-anyscale can-anyscale force-pushed the can-dev-06 branch 4 times, most recently from 8bbc81b to 6a4423e Compare September 7, 2023 12:32
@can-anyscale can-anyscale marked this pull request as ready for review September 7, 2023 13:02
@can-anyscale can-anyscale requested a review from krfricke as a September 11, 2023 02:55
@can-anyscale can-anyscale force-pushed the can-dev-06 branch 2 times, most recently from d370116 to ce96bde Compare September 11, 2023 03:25
@can-anyscale can-anyscale force-pushed the can-dev-05 branch 2 times, most recently from 81c0d0d to 8f100da Compare September 12, 2023 09:03
@can-anyscale can-anyscale force-pushed the can-dev-06 branch 2 times, most recently from ac434c9 to e2c9a5a Compare September 13, 2023 03:29
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
@can-anyscale
Copy link
Collaborator Author

Use os.environ.get for some buildkite envs, except for BUILDKITE_COMMIT which doesn't really make sense with any default empty value

Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale merged commit 680b268 into master Sep 22, 2023
@can-anyscale can-anyscale deleted the can-dev-06 branch September 22, 2023 02:42
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 26, 2023
Upload ray and ray-ml image for py38 and cu118 in civ2. Remove those two flavors in civ1 (which will also removes the uploading of base-deps and ray-deps)

Signed-off-by: can <can@anyscale.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Upload ray and ray-ml image for py38 and cu118 in civ2. Remove those two flavors in civ1 (which will also removes the uploading of base-deps and ray-deps)

Signed-off-by: can <can@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants