[Docker] Remove Kubectl #38524
Merged
[Docker] Remove Kubectl #38524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
aslonnie
reviewed
Aug 17, 2023
|
Oh, good point @aslonnie. @kevin85421 , do we need Kubectl in the Ray containers still? |
No, to the best of my knowledge. In Ray, only the Ray Autoscaler interacts with the Kubernetes cluster. However, it uses the |
aslonnie
approved these changes
Sep 11, 2023
ijrsvt
changed the title
|
Done!
Best,
Ian
Security @ Anyscale
…On Mon, Sep 11, 2023 at 10:25 AM Lonnie Liu ***@***.***> wrote:
***@***.**** approved this pull request.
update PR title and description?
—
Reply to this email directly, view it on GitHub
<#38524 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC5KQUZF5VMKFEJZICATI3XZ4NNJANCNFSM6AAAAAA3TEJEDM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
merged, but some of the k8s chaos tests are failing? not sure if I made a mistake or not.. |
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
Ray no longer needs kubectl. It was used for the old "kubernetes cluster launcher." KubeRay does not require that Kubectl is installed to run. Signed-off-by: Ian Rodney <ian.rodney@gmail.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Ray no longer needs kubectl. It was used for the old "kubernetes cluster launcher." KubeRay does not require that Kubectl is installed to run. Signed-off-by: Ian Rodney <ian.rodney@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray no longer needs
kubectl. It was used for the old "kubernetes cluster launcher." KubeRay does not require that Kubectl is installed to run.Kubernetes moved to a new location to host packages https://kubernetes.io/blog/2023/08/15/pkgs-k8s-io-introduction/The old package locations did not support newer versions of kubectl :(Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.