[Dependencies] Remove kubernetes requirement
#36333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
architkulkarni
requested review from
richardliaw,
ericl,
edoakes,
wuisawesome,
DmitriGekhtman and
a team
as code owners
|
Assigning @iycheng as a codeowner from Ray Core |
ijrsvt
reviewed
Jun 12, 2023
Comment on lines
1
to
5
| # Source: | ||
| # https://github.com/kubernetes-client/python/blob/master/kubernetes/utils/quantity.py | ||
| from decimal import Decimal, InvalidOperation | ||
|
|
||
|
|
There was a problem hiding this comment.
This LGTM as this code has remained pretty much static in the upstream.
fishbone
approved these changes
Jun 12, 2023
edoakes
approved these changes
Jun 12, 2023
…ve-kubernetes-import
|
huggingface_text_classification broken on master, unrelated |
architkulkarni
added
the
tests-ok
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
The kubernetes package is installed with ray["all"] but it's currently only used in two places: A helper function for converting units The GCS FT on K8s release test: ray/release/k8s_tests/run_gcs_ft_on_k8s.py Line 4 in 4070624 from kubernetes import client, config, watch This PR removes kubernetes from Ray's dependencies and removes it from the Ray docker image. This change is needed to reduce the overall package size of ray["all"]. For the helper function, we vendor it from the upstream. For the release test, kubernetes is installed separately: ray/release/k8s_tests/app_config.yaml Line 13 in 4070624 - kubernetes . I've also added it to release/requirements.txt to be safe. Related issue number Closes ray-project#36331 --------- Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
kubernetespackage is installed withray["all"]but it's currently only used in two places:ray/release/k8s_tests/run_gcs_ft_on_k8s.py
Line 4 in 4070624
This PR removes
kubernetesfrom Ray's dependencies and removes it from the Ray docker image. This change is needed to reduce the overall package size ofray["all"].For the helper function, we vendor it from the upstream.
For the release test,
kubernetesis installed separately:ray/release/k8s_tests/app_config.yaml
Line 13 in 4070624
release/requirements.txtto be safe.Related issue number
Closes #36331
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.