Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] update grpc to 1.46.6 #32054

Merged
merged 5 commits into from
Feb 1, 2023
Merged

[Core] update grpc to 1.46.6 #32054

merged 5 commits into from
Feb 1, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jan 30, 2023 •
edited
Loading

Why are these changes needed?

#31956

Upgrade to a version of gRPC that GHSA-cfmr-vrgj-vqwv in Zlib
1.46.6 has this patch: grpc/grpc#31845

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 changed the title [Core] update grpc to 1.48.2 [Core] update grpc to 1.46.6 Jan 30, 2023
@scv119 scv119 linked an issue Jan 30, 2023 that may be closed by this pull request
[Dependency] Upgrade gRPC to 1.46.6 #31956
Closed
@scv119 scv119 marked this pull request as ready for review January 30, 2023 18:41
@cadedaniel
Copy link
Member

wonder why they have 1.47.3 released but not marked as latest...

@cadedaniel
Copy link
Member

also Release v1.51.1

rkooo567
rkooo567 approved these changes Jan 30, 2023
View reviewed changes
bazel/ray_deps_setup.bzl
sha256 = "e168777eb0fc14ea5a65749a2f53c095935a6ea65f38899a289808fb0c221dc4",
strip_prefix = "boringssl-4fb158925f7753d80fb858cb0239dff893ef9f15",
sha256 = "534fa658bd845fd974b50b10f444d392dfd0d93768c4a51b61263fd37d851c40",
strip_prefix = "boringssl-b9232f9e27e5668bc0414879dcdedb2a59ea75f2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required to change for grpc upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup according to the comments.

@scv119 scv119 merged commit 47bb652 into ray-project:master Feb 1, 2023
@scv119 scv119 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 1, 2023
@ggydush
Copy link

ggydush commented Mar 14, 2023 •
edited
Loading

Are there current issues with grpc>=1.50.0? Could the upper-bound pin be relaxed?

edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@scv119 @edoakes
[Core] update grpc to 1.46.6 (ray-project#32054)
23ccbff 
ray-project#31956

Upgrade to a version of gRPC that GHSA-cfmr-vrgj-vqwv in Zlib
1.46.6 has this patch: grpc/grpc#31845

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

Assignees

@cadedaniel cadedaniel

@rkooo567 rkooo567

@fishbone fishbone

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dependency] Upgrade gRPC to 1.46.6
5 participants
@scv119 @cadedaniel @ggydush @rkooo567 @fishbone