[docker/arm64] Build docker images (with suffix) for arm64 #31861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 23, 2023 10:25
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
added 2 commits
January 25, 2023 15:43
Signed-off-by: Kai Fricke <kai@anyscale.com>
amogkam
approved these changes
Jan 26, 2023
| @@ -636,6 +706,11 @@ def push_readmes(merge_build: bool): | |||
| required=True, | |||
| help="Whether to bypass checking if docker is affected", | |||
| ) | |||
| parser.add_argument( | |||
| "--suffix", | |||
| required=False, | |||
There was a problem hiding this comment.
we can specify choices here to avoid any mistakes when specifying the command in the buildkite pipeline
Suggested change
| required=False, | |
| required=False, | |
| choices=["aarm64"] |
There was a problem hiding this comment.
Good point, I'll add this with a constant. Thanks!
added 2 commits
January 26, 2023 09:36
added 2 commits
January 26, 2023 10:07
Signed-off-by: Kai Fricke <kai@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds Docker image builds for arm64 (aarch64). The images will be tagged with a suffix
-aarch64. In a future retagging step, we can combine the existing x86_64 images with the aarch64 images for true multiplatform images.Changes needed to make this work:
Please also note that aarch64 base images only exist for CUDA >= 11.2.
Lastly, we are not building ray-ml docker images. This is because not all current dependencies are compatible with aarch64 - specifically, tensorflow requires at least 1.10.1 and torch 1.13.0 does not seem to be released for linux aarch64.
Related issue number
Closes #31537
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.