Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Upgrade absl #30667

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[core] Upgrade absl #30667

merged 1 commit into from
Nov 28, 2022

Conversation

fishbone
Copy link
Contributor

Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com

Why are these changes needed?

Upgrade absl

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone
up
7a06e0d 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@scv119
Copy link
Contributor

scv119 commented Nov 28, 2022

Any changes we should be aware of?

@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 28, 2022
@fishbone
Copy link
Contributor Author

@scv119 I don't think there is any. absl::AnyInvocable is newly introduce which I might give it a try.

Also the new gRPC version require absl upgrade.

@fishbone fishbone merged commit 8f3e22d into ray-project:master Nov 28, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@fishbone @WeichenXu123
[core] Upgrade absl to Abseil LTS 20220623.1 (ray-project#30667)
3abc6fa 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@fishbone @tamohannes
[core] Upgrade absl to Abseil LTS 20220623.1 (ray-project#30667)
4b5b71b 
Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 approved these changes

Assignees

@scv119 scv119

@rkooo567 rkooo567

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishbone @scv119 @rkooo567