upgrade gtest to 1.12.1 #29902
Merged
upgrade gtest to 1.12.1 #29902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloem
force-pushed
the
upgrade-gtest
branch
from
95bc76c to
88dd4e4
Compare
Could you rebase with master and try again? |
Signed-off-by: Pablo E <pabloem@apache.org>
pabloem
force-pushed
the
upgrade-gtest
branch
from
88dd4e4 to
362ffa3
Compare
|
I checked, seems all the failed tests are unrelated. I'll merge the PR after mac tests pass. |
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Dec 6, 2022
…9164)" (ray-project#29… (ray-project#29196) This reverts the PR and fixes the test failures This also fixes a bug around _monitor_jobs API. the monitor job can be called on the same job twice now, which will break the event (because at the end of monitor job, we record the event that job is completed). The same completed event can be reported twice without the fix upgrade gtest to 1.12.1 (ray-project#29902) While working on ray-project#28209 I hit issue google/googletest#3514, which causes a couple gtest-dependent tests to be unable to build Signed-off-by: Pablo E <pabloem@apache.org>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
While working on ray-project#28209 I hit issue google/googletest#3514, which causes a couple gtest-dependent tests to be unable to build Signed-off-by: Pablo E <pabloem@apache.org> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
bazel test //:actor_manager_testWhy are these changes needed?
While working on #28209 I hit issue google/googletest#3514, which causes a couple gtest-dependent tests to be unable to build
Related issue number
Upgrades gtest to avoid google/googletest#3514
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.