[build] Fix redis build in linux. #29179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
The current build in some platform will show errors:
```
Execution platform: @local_config_platform//:host
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-cli': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-benchmark': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-check-rdb': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-sentinel': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-server': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/bin/redis-check-aof': Permission denied
rm: cannot remove 'tmp-redis-bin/redis/include': Permission denied
```
This PR fixed this by avoiding creating tmp dir.
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com
Why are these changes needed?
The current build in some platform will show errors:
This PR fixed this by avoiding creating tmp dir.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.